fix: Limit the fidelity timelock b/w 3-6months in maker config #727
+120
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xEgao
force-pushed
the
timelock-limit
branch
2 times, most recently
from
4a2edbe to
6712d45
Compare
0xEgao
force-pushed
the
timelock-limit
branch
from
6712d45 to
df3cf62
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #727 +/- ##
===========================================
+ Coverage 68.87% 80.81% +11.94%
===========================================
Files 35 49 +14
Lines 4932 14442 +9510
===========================================
+ Hits 3397 11672 +8275
- Misses 1535 2770 +1235 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #664
Note-: The need of moving the
verify_fidelity_checkstowallet/fidelitymodule is because it callsfidelity_redeemscriptwhich is a private api now.